pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Rework - Inputs management to include all gamepad mapping V2

Open Greenlamp2 opened this issue 9 months ago • 5 comments

original PR: https://github.com/pagefaultgames/pokerogue/pull/390

Plugins feature has been removed since it does not work correctly on prod. It has been converted into an object with a reference to the battle-scene.

Greenlamp2 avatar May 03 '24 20:05 Greenlamp2

it should not break like yesterday, but if it does, you still can press the revert button 🥇

Greenlamp2 avatar May 04 '24 00:05 Greenlamp2

Some food for later: one benefit of this code, it's later, we could add an option to let the user set custom mapping IG. It also allow to know which source sent the input, it could be use to change the key display IG to match the peripheral used.

Greenlamp2 avatar May 04 '24 00:05 Greenlamp2

Once again working locally for me, only thing I noticed: (I have an 8bitdo controller so it might not map the same as an xbox controller so keep that in mind)

  • all the cycle buttons seem to be on the shoulders other than cycle nature which for me is on the "X" button. Is that intentional or just because my controller is 3rd party

brain-frog avatar May 04 '24 22:05 brain-frog

Once again working locally for me, only thing I noticed: (I have an 8bitdo controller so it might not map the same as an xbox controller so keep that in mind)

  • all the cycle buttons seem to be on the shoulders other than cycle nature which for me is on the "X" button. Is that intentional or just because my controller is 3rd party

Thank you for your review. Indead it's the intentional behaviour.

here are what were the input(right now on prod): IMG_9607

and here's the mapping of this PR: IMG_9608

W for west and N for north of course

Greenlamp2 avatar May 04 '24 22:05 Greenlamp2

gotcha I missed cycle form, that works

brain-frog avatar May 04 '24 22:05 brain-frog

adapated the code to integrate changes from: https://github.com/pagefaultgames/pokerogue/pull/474 and solve the issue: https://github.com/pagefaultgames/pokerogue/issues/487

Greenlamp2 avatar May 05 '24 14:05 Greenlamp2