pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

[Test] Change `doAttack()` to `selectMove()` in tests

Open DayKev opened this issue 6 months ago • 6 comments

What are the changes?

There are no user-facing changes.

Why am I doing these changes?

The function being named doAttack() can cause confusion, leading people to believe it will execute the attack when actually it's just selecting it in the menus and not running the phases forward.

What did change?

doAttack() was changed to selectMove() in src/test/utils/gameManager.ts

How to test the changes?

npm run test

Checklist

  • [x] I'm using beta as my base branch
  • [x] There is no overlap with another PR?
  • [x] The PR is self-contained and cannot be split into smaller PRs?
  • [x] Have I provided a clear explanation of the changes?
  • ~[ ] Have I considered writing automated tests for the issue?~
  • [x] Have I tested the changes (manually)?
    • [x] Are all unit tests still passing? (npm run test)
  • ~[ ] Are the changes visual?~
    • ~[ ] Have I provided screenshots/videos of the changes?~

DayKev avatar Aug 16 '24 00:08 DayKev