pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

[QOL] Candy Upgrade Notification Rework

Open josericardo-fo opened this issue 6 months ago • 4 comments

What are the changes?

Remake of #2808 Reworked the Candy Upgrade Notification logic to take account of the new "Buy Egg" option.

Why am I doing these changes?

A new mechanic was implemented (Buying Eggs).

What did change?

The logic of the 'On' setting.

Screenshots/Videos

Before (Look at Spearow)

image

After

image

How to test the changes?

Test if the candy icon appears whenever you can buy eggs.

Checklist

  • [X] There is no overlap with another PR?
  • [X] The PR is self-contained and cannot be split into smaller PRs?
  • [X] Have I provided a clear explanation of the changes?
  • [X] Have I tested the changes (manually)?
    • [X] Are all unit tests still passing? (npm run test)
  • [X] Are the changes visual?
    • [X] Have I provided screenshots/videos of the changes?

josericardo-fo avatar Aug 01 '24 02:08 josericardo-fo