[Mirror][Feature] Fusion Names Overhaul
What are the changes?
Mirror of #2545 Closes #2383
For detailed rules on fusion names, please refer to #2383.
@amatsune created a python script in the original PR to generate prefixes and suffixes.
@sodaMelon created a program to check if different Pokémon have the same prefix and preview random fusion names.
Why am I doing these changes?
The owner of the previous PR seems to have stopped working on it.
What did change?
Resolve conflict with latest beta branch.
Screenshots/Videos
⬜: To be translated 🟩: To be proofread ✅: Proofread
🟩En
🟩Es
🟩It
✅Fr
🟩De (From original PR)
✅Pt-BR
✅zh-CN
✅zh-TW
✅Ko
✅Ja
How to test the changes?
start a Endless(Spliced) game
Checklist
- [x] There is no overlap with another PR?
- [x] The PR is self-contained and cannot be split into smaller PRs?
- [x] Have I provided a clear explanation of the changes?
- [x] Have I tested the changes (manually)?
- [x] Are all unit tests still passing? (
npm run test)
- [x] Are all unit tests still passing? (
- [x] Are the changes visual?
- [x] Have I provided screenshots/videos of the changes?
hi i would use suggestion, but there are many new affixes for fusion pokemon in Korean update. https://github.com/mercurius-00/pokerogue/pull/3 <- so, could you check this PR in your repository? i think it's better to read&merge.
@mercurius-00 Can you add Japanese locales when you merge latest beta and resolve conflicts?
If English works, Spanish works. We use the same names for Pokémon.
Can't wait to see what hideous names will show -- at least clarity issue will be fixed.
This is gigantic. Please just ping me in the discord server when this is 100% approved by all languages
If English is fine, so is Spanish, in this case.
Unfortunately, I'm not sure about that English is fine, because many of the semantic roots have been disrupted according to the original vowel-consonant rules. So far, there hasn't been a native English speaker to verify these texts.
Perhaps you could check the Spanish. I could then use that as a basis to revise the English. There are still about twenty Pokemon names that differ between the English and Spanish though(mostly paradox pokemon).
different pm names:
- type_null
- great_tusk
- scream_tail
- brute_bonnet
- flutter_mane
- slither_wing
- sandy_shocks
- iron_treads
- iron_bundle
- iron_hands
- iron_jugulis
- iron_moth
- iron_thorns
- roaring_moon
- iron_valiant
- walking_wake
- iron_leaves
- gouging_fire
- raging_bolt
- iron_boulder
- iron_crown
It's a double inversion, you swap the order: poke1 and poke2 become poke2 and poke1, and you need to swap what you're fetching, poke2-prefix and poke1-suffix
Before the second swap I was getting poke2 suffix and poke1 prefix, or poke1 suffix and poke2 prefix, either way, I think the latter. Either way, needed to fix the order
Ah, now I get it. If possible, I'd add comments at those swaps just to make it easier to understand for people in the future (as far as the swapping is to shuffle the prefix and suffix of the two and then re-shuffle them so they fit back together as intended). Otherwise, lgtm 👍🏼
I took the liberty to adapt the json stuff. Please check again @pagefaultgames/translation-team
There's 242 conversations that need to be resolved before merging. Give me a ping if this is tested and ready to merge.
Please resolve conversations + merge conflicts before putting it back into review
Never meant to close it, sorry.
@mercurius-00 are you still working on this?