pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

[Mirror][Feature] Fusion Names Overhaul

Open mercurius-00 opened this issue 1 year ago • 12 comments

What are the changes?

Mirror of #2545 Closes #2383

For detailed rules on fusion names, please refer to #2383.

@amatsune created a python script in the original PR to generate prefixes and suffixes.

@sodaMelon created a program to check if different Pokémon have the same prefix and preview random fusion names.

Why am I doing these changes?

The owner of the previous PR seems to have stopped working on it.

What did change?

Resolve conflict with latest beta branch.

Screenshots/Videos

⬜: To be translated 🟩: To be proofread ✅: Proofread

🟩En

image

🟩Es

image

🟩It

image

✅Fr

image

🟩De (From original PR)

image

✅Pt-BR

image

✅zh-CN

image

✅zh-TW

image

✅Ko

image

✅Ja

image

How to test the changes?

start a Endless(Spliced) game

Checklist

  • [x] There is no overlap with another PR?
  • [x] The PR is self-contained and cannot be split into smaller PRs?
  • [x] Have I provided a clear explanation of the changes?
  • [x] Have I tested the changes (manually)?
    • [x] Are all unit tests still passing? (npm run test)
  • [x] Are the changes visual?
    • [x] Have I provided screenshots/videos of the changes?

mercurius-00 avatar Jul 31 '24 03:07 mercurius-00

hi i would use suggestion, but there are many new affixes for fusion pokemon in Korean update. https://github.com/mercurius-00/pokerogue/pull/3 <- so, could you check this PR in your repository? i think it's better to read&merge.

sodaMelon avatar Aug 06 '24 04:08 sodaMelon

@mercurius-00 Can you add Japanese locales when you merge latest beta and resolve conflicts?

EnochG1 avatar Aug 07 '24 23:08 EnochG1

If English works, Spanish works. We use the same names for Pokémon.

Can't wait to see what hideous names will show -- at least clarity issue will be fixed.

AsdarDevelops avatar Aug 08 '24 14:08 AsdarDevelops

This is gigantic. Please just ping me in the discord server when this is 100% approved by all languages

Tempo-anon avatar Aug 08 '24 19:08 Tempo-anon

If English is fine, so is Spanish, in this case.

Unfortunately, I'm not sure about that English is fine, because many of the semantic roots have been disrupted according to the original vowel-consonant rules. So far, there hasn't been a native English speaker to verify these texts.

Perhaps you could check the Spanish. I could then use that as a basis to revise the English. There are still about twenty Pokemon names that differ between the English and Spanish though(mostly paradox pokemon).

different pm names:
  1. type_null
  2. great_tusk
  3. scream_tail
  4. brute_bonnet
  5. flutter_mane
  6. slither_wing
  7. sandy_shocks
  8. iron_treads
  9. iron_bundle
  10. iron_hands
  11. iron_jugulis
  12. iron_moth
  13. iron_thorns
  14. roaring_moon
  15. iron_valiant
  16. walking_wake
  17. iron_leaves
  18. gouging_fire
  19. raging_bolt
  20. iron_boulder
  21. iron_crown

mercurius-00 avatar Aug 09 '24 02:08 mercurius-00

It's a double inversion, you swap the order: poke1 and poke2 become poke2 and poke1, and you need to swap what you're fetching, poke2-prefix and poke1-suffix

Before the second swap I was getting poke2 suffix and poke1 prefix, or poke1 suffix and poke2 prefix, either way, I think the latter. Either way, needed to fix the order

amatsune avatar Aug 14 '24 04:08 amatsune

Ah, now I get it. If possible, I'd add comments at those swaps just to make it easier to understand for people in the future (as far as the swapping is to shuffle the prefix and suffix of the two and then re-shuffle them so they fit back together as intended). Otherwise, lgtm 👍🏼

xsn34kzx avatar Aug 14 '24 05:08 xsn34kzx

I took the liberty to adapt the json stuff. Please check again @pagefaultgames/translation-team

flx-sta avatar Aug 28 '24 16:08 flx-sta

There's 242 conversations that need to be resolved before merging. Give me a ping if this is tested and ready to merge.

Tempo-anon avatar Sep 02 '24 05:09 Tempo-anon

Please resolve conversations + merge conflicts before putting it back into review

flx-sta avatar Sep 25 '24 14:09 flx-sta

Never meant to close it, sorry.

flx-sta avatar Sep 25 '24 14:09 flx-sta

@mercurius-00 are you still working on this?

flx-sta avatar Oct 02 '24 15:10 flx-sta