pokerogue
pokerogue copied to clipboard
add hazard removal for Rapid Spin, Defog, Tidy Up, Mortal Spin
This PR implements hazard removal via Rapid Spin, Defog, Tidy Up, and Mortal Spin. Logic is mostly copied over from screens removal logic. PR does not address Court Change.
I'm having a hard time building this, so if someone could test it out that would be great, but the logic seems to check out.
Hey can you add me as a contributor on this so I can change some of the code. adding some better templating and respecting which user performed the move.
Hey can you add me as a contributor on this so I can change some of the code. adding some better templating and respecting which user performed the move.
Added, thanks for checking it out
Is there a reason for the duplicated code in the if/else logic? We should be able to remove the else statement and make the player sided hazard removal implemented outside of the if statement.
Is there a reason for the duplicated code in the if/else logic? We should be able to remove the else statement and make the player sided hazard removal implemented outside of the if statement.
The structure imitates the screens removal logic one block underneath, no particular reason otherwise - just figured homogeneity would be good