pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

add hazard removal for Rapid Spin, Defog, Tidy Up, Mortal Spin

Open kenniky opened this issue 10 months ago • 4 comments

This PR implements hazard removal via Rapid Spin, Defog, Tidy Up, and Mortal Spin. Logic is mostly copied over from screens removal logic. PR does not address Court Change.

I'm having a hard time building this, so if someone could test it out that would be great, but the logic seems to check out.

kenniky avatar Apr 23 '24 04:04 kenniky

Hey can you add me as a contributor on this so I can change some of the code. adding some better templating and respecting which user performed the move.

amdevgwen avatar Apr 23 '24 06:04 amdevgwen

Hey can you add me as a contributor on this so I can change some of the code. adding some better templating and respecting which user performed the move.

Added, thanks for checking it out

kenniky avatar Apr 23 '24 07:04 kenniky

Is there a reason for the duplicated code in the if/else logic? We should be able to remove the else statement and make the player sided hazard removal implemented outside of the if statement.

WingofaGriffin avatar May 03 '24 23:05 WingofaGriffin

Is there a reason for the duplicated code in the if/else logic? We should be able to remove the else statement and make the player sided hazard removal implemented outside of the if statement.

The structure imitates the screens removal logic one block underneath, no particular reason otherwise - just figured homogeneity would be good

kenniky avatar May 06 '24 01:05 kenniky