pokerogue
pokerogue copied to clipboard
pagefaultgames
Implements cursed body
couldn't figure out a more elegant way of getting the attacker and move data into the getTriggerMessage function, open to suggestions about improvement. I imagine the args[] array could be used but it's not obvious to me how.
Does it still disable struggle? That's the only concern I have since like you said, the other troublesome factors are either unimplemented or super edge cases
From my testing, never disabled struggle. However, it also never disables a move if the pokemon with Cursed Body fainted. Have you checked against that?
https://bulbapedia.bulbagarden.net/wiki/Cursed_Body_(Ability)
@bennybroseph good call, added the bypassFaint() tag that we use for similar abilities. Now working as intended. Tested by setting chance to 100%, and with these overrides.
Okay, looks to be working. Glad I checked again though. The message that plays when an enemy's move is no longer disabled doesn't specify who the message is for. Very confusing in this fight when we both had tackle. The one when someone is disabled plays properly
https://github.com/pagefaultgames/pokerogue/assets/13838608/d7ff9443-fad0-42d5-9d2b-10dd268af2a9
It applies the same tag that disable does, so the messages are the same. But I just updated the messages to clarify which pokemon's move it is now. For both cursed body and disable.
Still getting a confusing message. I see the code as updated to include the Pokemon's name, but it's not clear if it was you or the opponent
For reference, the image is of the enemy Houndoom no longer being disabled.
Now sticking the prefix on the front, will be consistent with our other messages now
Looks like there's an extra space in the message here:
Same here for trainer's pokemon:
For comparison: