pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Published 20 hours ago • verified publisher icon pagefaultgames

Implemented Disguise

Open NxKarim opened this issue 10 months ago • 1 comments

Working good, it is based on the Pokémon received hitCount that resets when battle changes. (Same as Rage Fist) A HP condition could balance it if its thought to trigger to much, and, or switch in condition. Could not test for Substitute. Hope it helps!

NxKarim avatar Apr 17 '24 09:04 NxKarim

I feel like it would be best if this didn't change the whitespacing for dozens of lines unrelated to this change, it makes it more difficult to tell what is actually being changed when hundreds of unrelated lines have been changed as well. A PR for improving consistency on that may be a good idea, but probably not this one.

Also to confirm, you've tested how it interacts with being broken and going into a new battle? Because at a glance it looks like it'd wait till the end of the first turn to transform back into normal mode.

Xavion3 avatar Apr 17 '24 09:04 Xavion3

Sorry for the white spaces, I will close this PR and make a new one without that and a few tweaks.

NxKarim avatar Apr 17 '24 23:04 NxKarim