pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Feature: Finish Magnet Pull and clauses for Arena Trap

Open td76099 opened this issue 9 months ago • 1 comments

@Piefrenzy on Discord

As per Bulbapedia, Arena Trap does not affect Pokemon that are not grounded, and Magnet Pull only affects Steel type Pokemon and none others. Clauses have been added to the applyCheckTrapped function to facilitate this.

I did see .condition((pokemon: Pokemon) => pokemon.getOpponent()?.isOfType(Type.STEEL)) commented out under Magnet Pull. I was working on trying to implement something easy like that, but there didn't seem to be a way to do. Another way of thinking about it is these abilities are technically always active, but it requires opponent Pokemon to meet certain conditions to be affected by them.

Ghost type not blocked by Shadow Tag

https://github.com/pagefaultgames/pokerogue/assets/85713900/18cf582a-105d-43ee-aa16-bbb9795727af

Magnet Pull trapping a Steel type

https://github.com/pagefaultgames/pokerogue/assets/85713900/aa62c8bb-1143-4224-9bce-ac2587fe5d75

Pokemon with the Levitate ability not getting blocked by Arena Trap

https://github.com/pagefaultgames/pokerogue/assets/85713900/f8b88485-0a3a-4157-8256-0b5ab8757f7d

Flying type not getting blocked by Arena Trap

https://github.com/pagefaultgames/pokerogue/assets/85713900/a9632942-0e10-4669-9c2b-ab21dae10d10

td76099 avatar May 21 '24 05:05 td76099