pokerogue icon indicating copy to clipboard operation
pokerogue copied to clipboard

Classic Mode - Add ribbon to both pokemon species when there is fusion

Open ReneGV opened this issue 9 months ago • 6 comments

Implementing this issue: https://github.com/pagefaultgames/pokerogue/issues/1072

Add a ribon to both pokemon species whenever a pokemon is a fussion.

ReneGV avatar May 18 '24 04:05 ReneGV

This isn't a bug it's intended behaviour. Otherwise you would expect to get two tickets, one for each pokemon in the fusion so if you win classic with a full party of fusions you get twice the tickets. If you added a ribbon to both but not tickets it would also then be confusing because you would have pokemon with ribbons but they haven't redeemed a ticket yet for winning classic with them

j-diefenbach avatar May 18 '24 07:05 j-diefenbach

This isn't a bug it's intended behaviour. Otherwise you would expect to get two tickets, one for each pokemon in the fusion so if you win classic with a full party of fusions you get twice the tickets.

@j-diefenbach Yep I agree, however the awardRibbon method I used also to do ticket rewards. https://github.com/pagefaultgames/pokerogue/blob/408e3b507e31132f0e030acac040b620740d4bb8/src/phases.ts#L3723-L3730 So if you beat the game with a party full of fussions you would indeed get the double amount of tickets.

If you fuse pokemon A and B, both texts: A beat classic for first time, you received ... B beat classic for first time, you received ... will be displayed, so it is not confusing why you received double tickets

ReneGV avatar May 18 '24 07:05 ReneGV

So if you beat the game with a party full of fussions you would indeed get the double amount of tickets.

Yeah my opinion is that this is sorta unbalanced. Obviously it's not game breaking but I think it makes sense you only get the ribbon and ticket for the base pokemon. This has most likely been considered before and I'm sure the devs originally decided not to do it that way.

j-diefenbach avatar May 18 '24 08:05 j-diefenbach

I may be missing some strat to get lots of DNA splicers in classic but i rarely ever get one, never even got more than 2 in a single run, I dont think this is unbalanced

jaimefd avatar May 18 '24 14:05 jaimefd

Originally the main reason to prevent this was we didn't want a case where a player would have Pokemon A fused with Pokemon B but be missing Pokemon B's starter dex entry which would result in a weird case of missing a dex entry but having a ribbon. However, since this only applies to classic mode, the only way to own a fusion is to have both component starters owned and DNA splicers are super rare, I'm not completely opposed to this change.

Tempo-anon avatar May 19 '24 04:05 Tempo-anon

Thanks for your feedback @TempsRay. It looks there is consensus that this change is not unbalanced Please let me know if there is work remaining to do in order to get approval,

ReneGV avatar May 21 '24 05:05 ReneGV