Pablo Andres Fuente

Results 65 comments of Pablo Andres Fuente

I didn't add it because I wasn't able to find [Jesusemora](https://github.com/Jesusemora) email. But the link that you shared mentions something about `no-reply` email. I'll try to use it.

@Repiteo https://github.com/godotengine/godot/pull/85109 should also be closed

I'm not sure if the process of submitting a PR involves saying that it's ready for review, but just in case, I'm saying it.

I know the test is really silly and not add too much value, but as I mentioned the idea was to trigger the discussion around FakeIt and HTTPRequest constructor change....

Regarding extending the class to mock it, I did that in the past and it ended up being me writing more code on the mock than in actual tests. Using...

> EDIT: See [tests/core/test_crypto.h](https://github.com/godotengine/godot/blob/master/tests/core/test_crypto.h) for an example where we use a mock class and all the checks are in the test cases (and not in the mock class as you...

Well, this time I decided to change to a simpler Mocking library and I added some new tests that uses it. Of course those tests are quite simple, but it's...

I manged to add some more tests and get green on all checks. Can I get a new review? As I mentioned, after I got this merge l will add...