rTPC icon indicating copy to clipboard operation
rTPC copied to clipboard

rTPC pkgdown edits

Open padpadpadpad opened this issue 11 months ago • 7 comments

With the new changes to the website - which i generally love - a couple of things to fix:

  • for some reason the rTPC badge is HUGE on the homepage. (think this can be solved using the extra.css in pkgdown folder: solved using https://github.com/r-lib/pkgdown/issues/2159
  • on automode and light mode the colours of the text on the navbar need some work: https://github.com/r-lib/pkgdown/issues/2703 feels like this should help.
  • get rid of background colour on the figures on the homepage

padpadpadpad avatar Jan 15 '25 13:01 padpadpadpad

Yeah I did spot a few of those! Slightly weird that I never had these problems with other setups, but I guess it's from migrating up from an older version rather than initialising at this version of pkgdown.

I can compare the underlying setup against ohvbd or roz, both of which use the same techniques and don't have these problems.

I do think though that I used an SVG for the package logo, which possibly uses different mechanisms to control size.

The nav colours are weird as anything, because that definitely doesn't happen on the ohvbd documentation.

ohvbd yaml

I do wonder whether it's bootswatch that's causing the issues? Something is causing --bs-nav-link-color to be set different between the two. Bootstrap version is the same.

fwimp avatar Jan 16 '25 12:01 fwimp

Currently playing with it, think I've found a solution. Update incoming post-test :)

fwimp avatar Jan 16 '25 13:01 fwimp

Yup it was bootswatch. Not a clue why but removing it has made things better :)

fwimp avatar Jan 16 '25 13:01 fwimp

Image

Something still looking a little odd with the logo.

I think the the width in extra.css should be 259px, not 300px (as the logo is not actually a square)

fwimp avatar Jan 16 '25 16:01 fwimp

A fat boi. Ahahahaha. Sorry about all this! I have pushed a change and should help!

padpadpadpad avatar Jan 16 '25 16:01 padpadpadpad

Perrrrrfect, looks good now! Phew, think that's now at a good point :)

Still need to change up the figures at some point, but that's less of a core concern as at least they don't look tooooo out of place.

fwimp avatar Jan 16 '25 17:01 fwimp

Figures changed.

padpadpadpad avatar Feb 12 '25 16:02 padpadpadpad