burrito icon indicating copy to clipboard operation
burrito copied to clipboard

feat: add ability to manually sync layers

Open LucasMrqes opened this issue 1 year ago • 4 comments

image image image

LucasMrqes avatar Aug 30 '24 15:08 LucasMrqes

@LucasMrqes If you create a TerraformRun directly that would be easier I think and should still work, you'd have to make sure there's no other TerraformRun running but apart from that it should be straightforward to implement plan/apply buttons

AlanLonguet avatar Sep 02 '24 14:09 AlanLonguet

@LucasMrqes If you create a TerraformRun directly that would be easier I think and should still work, you'd have to make sure there's no other TerraformRun running but apart from that it should be straightforward to implement plan/apply buttons

I think using the controller to generate the run is a better way. I tried to create the run resource with the server and encountered the following issues:

  • The status of the layer is not updated, thus making the layer status + run history incoherent and messing with how the server finds the last run in its /layers path. (unless we duplicate this logic in the server as well)
  • Not using the controller to generate runs makes it complicated to debug using the manual sync Button, as the run creation logic is somewhat duplicated and the button would bypass the ususal flow of creating run/pods with Burrito
  • Overall, the required logic is way more complicated

wdyt @Alan-pad ?

LucasMrqes avatar Sep 06 '24 14:09 LucasMrqes

I think we can adapt the controller logic so the new runs are picked up

AlanLonguet avatar Sep 09 '24 14:09 AlanLonguet

Implementing this feature with a tfrun creation requires us to rework the logic of the layer controller. This is something that we plan to do, but since this feature is requested a lot by Burrito users, we will merge this as is and work on a rework on future versions of Burrito.

LucasMrqes avatar Sep 27 '24 15:09 LucasMrqes