buckaroo icon indicating copy to clipboard operation
buckaroo copied to clipboard

Reproduce_summary falsely inserts values into the summary_series

Open paddymul opened this issue 1 year ago • 0 comments

Checks

  • [X] I have checked that this issue has not already been reported.

  • [X] I have confirmed this bug exists on the latest version of Buckaroo.

What type of jupyter notebook were you using (VSCode notebook, google colab, Jupyter Lab, Jupyter notebook). Select multiple if you can reproduce this in multiple environments. If other, please add to description.

Jupyter Lab

Reproducible example

Issue description

def reproduce_summary(ser_name, kls, summary_df, err, operating_df_name):
    ssdf = safe_summary_df(summary_df, kls.requires_summary)

analysis_management:reproduce_summary is supposed to give a snippet that represents what the failing ColAnalysis was called with for summary series. safe_sumary_df, makes sure that the summary_df is filled out... even with nans, but safe_summary_df isn't called in the execution flow. This leads to erroneous reproduce statements

Expected behavior

reproduce_summary should return the exact arguments a ColAnalysis summary function was called with

Installed versions

``` Selected Jupyter core packages... executing in jupyter-lab buckaroo : 0.4.5 jupyterlab : 3.6.5 notebook : 6.5.6 ipywidgets : 8.1.1 traitlets : 5.13.0 jupyter_core : 5.5.0 pandas : 2.1.1 numpy : 1.26.0 IPython : 8.17.2 ipykernel : 6.26.0 jupyter_client : 7.4.9 jupyter_server : 2.10.1 nbclient : 0.9.0 nbconvert : 7.11.0 nbformat : 5.9.2 qtconsole : not installed buckaroo : /Users/paddy/buckaroo/buckaroo/__init__.py jupyterlab : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/jupyterlab/__init__.py notebook : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/notebook/__init__.py ipywidgets : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/ipywidgets/__init__.py traitlets : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/traitlets/__init__.py jupyter_core : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/jupyter_core/__init__.py pandas : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/pandas/__init__.py numpy : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/numpy/__init__.py IPython : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/IPython/__init__.py ipykernel : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/ipykernel/__init__.py jupyter_client : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/jupyter_client/__init__.py jupyter_server : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/jupyter_server/__init__.py nbclient : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/nbclient/__init__.py nbconvert : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/nbconvert/__init__.py nbformat : /Users/paddy/anaconda3/envs/buckaroo-dev-3/lib/python3.11/site-packages/nbformat/__init__.py qtconsole : not installed ```

Jupyter Log output

No response

paddymul avatar Nov 15 '23 22:11 paddymul