Kyle Robbertze

Results 237 comments of Kyle Robbertze

I've started answering this a couple times, but ran out of time each attempt, so sorry for that. I'm concerned about how this workflow interacts with C4. We're already deviating...

Aside from C4, I don't see any issues with doing things the way you suggest

You mention a block, is that what is scheduled in the show?

> Right now, we only allow read only access on some resources for the public, read only with the api key for internal communication and the read/write for the admin,...

We already use model bakery in the API as a model factory for testing. How does factory_boy compare?

Hiding this behind a feature-flag is a good idea. Having some sort of feature-flag framework for experimental features in general may be something that we should look into

Thanks for your work and I hope to have a look through it later today! Please keep the 2 features (PHP updates and Liquidsoap) in separate PRs - this helps...

> We are missing an error schema for our API error responses. Returning a simple HTTP status code is not enough. Do we want to define it here or merge...

Do you have the logs from the legacy container too?