pact-python icon indicating copy to clipboard operation
pact-python copied to clipboard

Ruff Pattern Matching

Open JP-Ellis opened this issue 2 years ago • 1 comments

Have you read the Contributing Guidelines on issues?

Prerequisites

  • [X] I'm using the latest version of pact-python.
  • [X] I have read the console error message carefully (if applicable).

Description

Ruff's exclude pattern matching is over-zealous, and patterns which should match files within a directory are instead recursive.

This is an upstream issue:

  • [ ] astral-sh/ruff#6262

Reproducible demo

No response

Steps to reproduce

  1. Checkout master
  2. Run ruff and note that nothing is fixed/raised

Expected behavior

  • Ruff should correctly lint files in v3 (both within Pact and tests)

Actual behavior

  • Ruff's ignore is overly eager.

Your environment

No response

Self-service

  • [X] I'd be willing to fix this bug myself.

JP-Ellis avatar Nov 06 '23 03:11 JP-Ellis

Re-opening as #459 is only a temporary workaround.

JP-Ellis avatar Nov 06 '23 04:11 JP-Ellis