pact-mock_service icon indicating copy to clipboard operation
pact-mock_service copied to clipboard

Published 20 hours ago • verified publisher icon pact-foundation

refactor: remove unused ansicolor dependency

Open Benjaminpjacobs opened this issue 3 years ago • 2 comments

The term-ansicolor gem injects a global Term module that has a high probability of naming collision for other common class names. This PR removes that gem from this repo as it is not used anywhere.

Benjaminpjacobs avatar Mar 02 '22 18:03 Benjaminpjacobs

I don't think this is necessary - it will auto update anyway with a bundle update.

bethesque avatar Mar 03 '22 22:03 bethesque

@bethesque this whole PR is unnecessary? My only concern is that if the gem is included, even if it's not referenced, it might still pollute the namespace.

Benjaminpjacobs avatar Mar 03 '22 23:03 Benjaminpjacobs

I think we can remove gem.add_runtime_dependency 'term-ansicolor', '~> 1.0' as its not used like you point out, but we don't need to update the pact-mock-service to fix to the patch version, the minor version will mean it will pick up the latest, 1.19.

I've included this in #141 Thanks!

YOU54F avatar May 11 '23 18:05 YOU54F