pacstall icon indicating copy to clipboard operation
pacstall copied to clipboard

feat: broken package checking

Open Elsie19 opened this issue 1 year ago • 2 comments

Purpose

Because of certain packages apparently borking multiple systems (wine-staging-git), I want to implement a system of guards where we can simply drop an entry into a file and declare a package quarantined, where users are warned of problems while still being able to install it if they wish.

Approach

The entries go in broken-packages in the repo root, and every pacscript download, it will check the file.

Addendum

https://github.com/pacstall/pacstall-programs/pull/6763 https://github.com/pacstall/pacstall-programs/issues/6357

Checklist

  • [x] I confirm that I have read the contributing guidelines, and this pull request is abiding by all the clauses stated in the guideline.

Elsie19 avatar Dec 19 '24 17:12 Elsie19

Idk if i like the idea of there being a main repo file that houses the info for all packages I think it’d be better if we checked for the existence of ${REPO}/packages/${PACKAGE}/.BROKEN

Also don’t forget to add the { ignore_stack=false; set -o pipefail; trap stacktrace ERR RETURN; } at func start

oklopfer avatar Dec 19 '24 19:12 oklopfer

True, because then we could check for pkgbase/pkgchild stuff like that as well 🤔

Elsie19 avatar Dec 19 '24 19:12 Elsie19