Paco Xu

Results 393 comments of Paco Xu

need upgrade prometheus client_golang first. Run `go mod vendor` **Updated**

ok @kzys thanks for your review. Updated

/cc @dmcgowan @mikebrow kindly ping as there is no update for more than a month.

> please rebase to make sure that CI is happy. thanks 🙏 @fuweid rebased and needs to wait for CI running.

> Not sure if it's a mandate, but other metrics in the repo are using docker/go-metrics for consistent naming. replace the implementation. Updated.

@cpuguy83 do you have time to take a look again?

ack /cc @samuelkarp @ruiwen-zhao as you are reviewing my other metrics PR.

> Non blocking and for my own education: how will the new metrics be used? More specifically, what issues will the new metrics help debug and how will they help?...