Costas Papastathis

@mhdawson https://github.com/sclorg/s2i-nodejs-container/pull/359/commits/06f9b3d4ecfe7780b48cd36b989a697ce4f9b589 https://github.com/sclorg/s2i-nodejs-container/pull/359/commits/d404db7f20ade18b07e957e00e20b234e28f5f89 https://github.com/sclorg/s2i-nodejs-container/pull/359/commits/cf13d07597009bea4c5182b0f341e989a6311919 I've added these commits, with docs about the init-wrapper and with some examples.

> @pacostas I'm looking for the part which enables INIT_WRAPPER to be used in the build part of S2i. I assume that somehow INIT_WRAPPER being set in env during built...

> @pacostas what I meant were the changes that allow > > > s2i -e INIT_WRAPPER=true build . buildImage node-app > > docker run node-app > > to work? Or...

@mhdawson sure ``` cd ./s2i-nodejs-container git remote add pacostas https://github.com/pacostas/s2i-nodejs-container.git git fetch --all git checkout command-option-on-14-and-16 # the name of the branch is a bit wrong, it should also include...

> > I also wondered if we could pull what npm start would have used from package.json ? > > Yes we can do that with bash code, working on...

> One other thing to check @pacostas should we add a test for this feature in - https://github.com/sclorg/s2i-nodejs-container/blob/master/test/run @mhdawson Thank you for the URL, although I'm not sure how tests...

@phracek I'm trying to add some tests and I cant find a way to run them locally while development. Is there any option for running them locally in a Fedora...

@phracek I've managed to add tests for the `NODE_CMD` and `INIT_WRAPPER` env variables on this commit https://github.com/sclorg/s2i-nodejs-container/pull/359/commits/92e17b9bd0854c18758b63270838fd5c80d9af68

I was able to reproduce it locally the issue for the 18-minimal on rhel8 and rhel9. Just pushed with the fixes.

@phracek Can you trigger once more the tests?