cmdk
cmdk copied to clipboard
[Accessibility] Use id instead of children
Closes #253
Values were not being read aloud when selected with mouse, arrow keys, etc. This is because:
- The
aria-activedescendantwas not being updated - The element with the
aria-activedescendantmust be focused to read the value it references aloud
Finding the selected item was previously done using a querySelector and encodeUri which is bad because if children are used instead of a string, this will not serialize well (As well as spaces, special characters, etc.). The new approach is more robust and uses the actual ID in the dom.
The focus issue is solved by changing the focus back to the command input, or outer list container when the value is updated.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cmdk-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 5, 2024 5:27am |