odbc-sys icon indicating copy to clipboard operation
odbc-sys copied to clipboard

add tests that exercise communication with an actual driver

Open lovasoa opened this issue 1 month ago • 5 comments

The CI config still needs tuning; opening the pr anyway in case you want to take on where I left off, @pacman82

lovasoa avatar Oct 25 '25 21:10 lovasoa

Remember, the issue which triggered this happend on linux / MacOS. It is not a strict requirement that this works on windows. It is fine if both for windows and iodbc only subset of tests run.

IMHO we do not need to test the full combination of every feature on every platform.

Hope this makes this simpler for you.

pacman82 avatar Oct 26 '25 17:10 pacman82

@pacman82 : I set up the full tests with drivers to run on windows macos and linux (using the the sqliteodbc driver). The vendored unixodbc feature is now fully tested on macos and linux. I'm quite happy with the result, and I'll feel more confident depending on it in sqlpage now that it's more extensively tested on ci.

I also included a quality of life improvement on macos that I discovered while setting this up. In unix-odbc/config.h we now set the necessary variables for the vendored unixodbc to discover brew-installed drivers automatically.

lovasoa avatar Oct 27 '25 14:10 lovasoa

Thanks. As said, I am a bit underwater at the moment. Yet, I'll take a closer look a it, once things cool down. Thanks for your contribution.

pacman82 avatar Oct 28 '25 19:10 pacman82

Hi @pacman82 ! Did you get the time to have a look at this ?

lovasoa avatar Nov 07 '25 20:11 lovasoa

Not, yet. Likely won't get a good look at it for another two weeks

pacman82 avatar Nov 08 '25 17:11 pacman82