Packt-Publishing-Free-Learning
Packt-Publishing-Free-Learning copied to clipboard
packt-cli
Lint the code with pylama
As code in this repo is becoming more and more compliant with PEP8 it would be nice to use pylama to lint it - it's easy to configure Travis to run pylama on every PR and warn about style issues in PR changes. Existing and harder to resolve issues could be ignored in pylama configuration and resolved later.
To be done:
- [ ] use pylint linter;
- [x] use mccabe linter;
- [x] use pycodestyle linter;
- [x] use pyflakes linter;
- [ ] use pydocstyle linter;
- [x] configure Travis task;
I have made a pull request with simple pylama configuration (that will configure pylama with mccabe, pycodestyle and pyflakes linters). Next I'll figure out how to configure Travis (but I suppose you will have to enable travis builds yourself as a repo owner).
OK, I have also added a Travis configuration in #73. Could you enable build on Travis (it should hopefully detect this branch whenever there will be a new push)?
Could you reopen this? There is still pylint and pydocstyle to be enabled.
Have we checked that Travis CI runs pylama when pull request is made/updated?
Also, from now we shouldn't push directly to master (can we secure this branch from pushing and leave pull requests as the only way of updating this?).
ok, sorry : )
- Yeah, check this out: https://travis-ci.org/igbt6/Packt-Publishing-Free-Learning