packit
Implement installability check for Packit as a Fedora dist-git CI
Run installability check for successful Koji scratch builds on Fedora dist-git pull-requests.
You can also consider defining another plan and putting it e.g. here. Maybe also making the upstream one usable both upstream and downstream.
This is a part of the phase 2 of https://github.com/packit/packit-service/issues/2692
At the risk of sounding like a scratched record, please make the installability check actually useful. Since you're implementing a new thing, it'd be great time to improve on what we had before.
Currently, it tries to install all packages in the build, which cannot work in many cases. https://pagure.io/fedora-ci/general/issue/448 has a long discussion and links to issues.
@keszybz thanks for bringing this up! We will take this into consideration.
Re: installing all pqckages, probably it would be sufficient to make the artifacts empty for those tests like setting skip_build.
Another issue brought up was to use rhel builders for epel-9.
Also installability tmt plan should be this one actually. Regarding the link to install-and-verify.sh link
Also installability tmt plan should be this one actually. Regarding the link to install-and-verify.sh link
That one is also linked in the description (the repo).
When implementing this, consider implementing the retriggering also, or create a follow-up issue.
Just discussed with AdamW and we might want to pick the current one (because of the following reasons) and improve later:
- No change in the test definition when changing Fedora CI to Packit.
- Despite it might be good to rewrite the check from scratch, we might learn from the existing one. (And avoid the same mistakes..;)
- We'll save time.
- We can discuss this on/around Flock (I've proposed a hackfest but there are interested people so we'll do it somehow nevertheless of it being accepted..;)
- All the issues mentioned in this issue would take quite some time to fix. (And we can't easily fix all before final phase.)
Most of the tmt plans in Fedora CI should be simple to port, since it only involves providing the appropriate Koji task ID and a few other environment variables. A bit unfortunate that you would have to navigate the implementation to find the necessary input, but some of them have it in the prepare step. It would be nice to consolidate the tests in a single repo, but better to defer that for after packit takes over Fedora CI.
Just an update, I'm still actively working on this, hopefully a PR with the implementation will appear soon.
