packit-service icon indicating copy to clipboard operation
packit-service copied to clipboard

OpenScanHub response URLs are not in https

Open Venefilyn opened this issue 1 year ago • 2 comments

What happened? What is the problem?

Checking the API we get http:// links to OSH instead of https://

What did you expect to happen?

Since OSH redirects anyway it should be https by default

Example URL(s)

See here for links to openscanhub.fedoraproject.org https://stg.packit.dev/api/osh-scans?page=1

Steps to reproduce

1.
2.
3.

What is the impacted category (job)?

Other

Workaround

  • [X] There is an existing workaround that can be used until this issue is fixed.

Participation

  • [ ] I am willing to submit a pull request for this issue. (Packit team is happy to help!)

Depends on openscanhub/fedora-infra#73

Venefilyn avatar Nov 14 '24 15:11 Venefilyn

Those are the links that we get from the OSH. I don't like this resolving of a problem of different service on our side (we're kinda doing that with Bodhi already…), it's just unnecessary complexity (as if there wasn't enough complexity already…) for Packit.

Please open up an issue against the OpenScanHub, they're open-source project after all…

mfocko avatar Nov 18 '24 08:11 mfocko

Opened https://github.com/openscanhub/openscanhub/issues/305 to track, if updated we could update packit DB to make it consistent :pray:

Venefilyn avatar Nov 18 '24 12:11 Venefilyn