packit-service icon indicating copy to clipboard operation
packit-service copied to clipboard

Open PRs with Packit config for new Fedora packages

Open lbarcziova opened this issue 1 year ago • 8 comments

This is a follow-up of the discussion on Flock, where this idea came up.

TODO:

  • [ ] integrate this into the workflow for the fedpkg request-repo, as described in the change proposal, with Packit option being opt-in
    • the request-repo code can be found here
    • the command creates issues in https://pagure.io/releng/fedora-scm-requests, example
    • the repos are created based on these issues, the code handling that should be here
    • consider including both options for creating PR and pushing the commit with Packit config directly
    • discuss the integration design with team
    • ask Fedora infra team if something from the process is unclear
  • [ ] open PRs
    • description should contain brief introduction to Packit and downstream automation capabilities (use https://hackmd.io/Q6lXSsueTf2Gz2lL13Gv0g)
    • PR should contain a default Packit configuration (static or created by packit dist-git init)

Notes from the change proposal

  • Think about how this could be done not just for new packages

lbarcziova avatar Aug 22 '24 08:08 lbarcziova

Here's a list of issues tracking new repositories being created so we can see the frequency: https://pagure.io/releng/fedora-scm-requests/issues?status=all&search_pattern=new+repo&close_status=

lachmanfrantisek avatar Aug 22 '24 10:08 lachmanfrantisek

We decided to make this a Fedora Change, here is an issue to file a Change Proposal.

nforro avatar Sep 27 '24 12:09 nforro

One note to the functionality itself we probably haven't considered so far, we should probably also handle adding the project to release-monitoring.org as this is now not automatic for new packages, and also enabling the monitoring (or just including these instructions in the PR description, though that would lead to worse UX).

lbarcziova avatar Sep 30 '24 10:09 lbarcziova

Today, we discussed the possibility of starting with the opt-in approach and waiting for Fedora Change with the opt-out, but agreed on not doing this and rather wait either for the approval or at least for the discussion around the change. The opt-in approach does not provide much benefit.

lachmanfrantisek avatar Oct 10 '24 08:10 lachmanfrantisek

In case we will still be running in the current cluster when implementing this, maybe we should also automatically get and check the sources of the newly created package, whether it is not blocked by the firewall (and enable it there in case yes?).

lbarcziova avatar Dec 16 '24 12:12 lbarcziova

fedpkg PR: https://pagure.io/fedpkg/pull-request/586

nforro avatar Jan 20 '25 16:01 nforro

The PR has been merged, I'm going to work on the second part of this issue.

nforro avatar Mar 18 '25 12:03 nforro

TODO:

  • [ ] Implement a new task in Packit Service triggered by a webhook
  • [ ] Set up a shared webhook secret in Packit Service and in Fedora Infra for the scm-request-processor poddler
  • [ ] Implement sending the webhook from SCMRequestProcessor.process_new_repo()

nforro avatar May 29 '25 12:05 nforro

Am I correct in thinking that fedpkg --onboard-packit currently has no effect? Would it be better to undocument that option until the rest of the functionality is plumbed in.

mavit avatar Nov 26 '25 16:11 mavit