packit-service
packit-service copied to clipboard
PACKIT_PACKAGE_NVR is incorrect
PACKIT_PACKAGE_NVR is assigned a NVR of the first entry in the list of built packages:
https://github.com/packit/packit-service/blob/719d997342008e89892eb4ac4ac5eef4d1325082/packit_service/worker/helpers/testing_farm.py#L454-L455
However, that doesn't necessarily have to be the "main" subpackage, and there is in fact no way to tell which subpackage is the main one, it could be any of them. So PACKIT_PACKAGE_NVR should either be a source package NVR or a list of all binary package NVRs.
Check how people is using this output and maybe consider providing both of them.
@LecrisUT I think you were the one that hit this problem. Can you please tell us which solution can solve your needs better; having a list of NVR(s) or having just the SRPM NVR? Thank you!
I am inclined towards srpm NVR. For me the main thing was consistency with Koji, and I believe that's what they use as well
If I remember it correctly @xsuchy was also suggesting the SRPM NVR. @nforro or @lachmanfrantisek do you think we can agree on the SRPM NVR? Or should we ask more users?
I think it makes sense, we can introduce another variable for the list of binary RPMs in the future if needed.