packit-service icon indicating copy to clipboard operation
packit-service copied to clipboard

Support branch push as a trigger for propose-downstream

Open lachmanfrantisek opened this issue 4 years ago • 6 comments

Requested by @pbrezina

Some users want to trigger the propose-downstream workflow on each commit to a specified branch.

TODO:

  • [ ] Mark the handler to support the commit trigger (via reacts_to).
    • https://github.com/packit/packit-service/blob/639c39422155fedc296892dcd5c2a90791be6797/packit_service/worker/handlers/distgit.py#L101-L107
  • [ ] Make sure the handler is run only for a specified branch.
    • See the CoprBuildHandler for inspiration: https://github.com/packit/packit-service/blob/639c39422155fedc296892dcd5c2a90791be6797/packit_service/worker/handlers/copr.py#L115-L127
  • [ ] In packit, improve the api.sync_release method to accept needed information (e.g. a new branch argument).
    • [ ] Make sure it takes the correct state of the repository. (Including the spec-version. There might be some code that makes sense only to release.)
    • [ ] Provide env.vars. in actions so the user can use this when determining version and sources.
    • [ ] Might be useful to add a new CLI option as well so it can be tested more easily.
  • [ ] Use the new argument when calling the Packit API.
  • [ ] Provide feedback via commit-statuses. (e.g. Task accepted, Sync in progress, PRs created)
    • It would be nice to create a table with the PR links in the check run description.
  • [ ] Document this feature.

lachmanfrantisek avatar Nov 15 '21 09:11 lachmanfrantisek

This issue has been marked as stale because it hasn't seen any activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are never marked as stale.)

stale[bot] avatar Mar 02 '22 09:03 stale[bot]

This issue has been marked as stale because it hasn't seen any activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are never marked as stale.)

stale[bot] avatar Jun 12 '22 19:06 stale[bot]

This issue has been marked as stale because it hasn't seen any activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are never marked as stale.)

stale[bot] avatar Sep 21 '22 02:09 stale[bot]

We did not prioritize this in over a year so I am going to close.

You can always push a tag in the branch that will trigger the propose-downstream process.

TomasTomecek avatar Dec 06 '22 12:12 TomasTomecek

Reopening since the Polkit team is interested in this..;)

lachmanfrantisek avatar Mar 24 '25 10:03 lachmanfrantisek

Podman team interested too.

lsm5 avatar May 19 '25 14:05 lsm5