ogr icon indicating copy to clipboard operation
ogr copied to clipboard

implement support for forgejo commit statuses

Open olamidepeterojo opened this issue 9 months ago • 10 comments

TODO:

  • [x] Write new tests or update the old ones to cover new functionality.
  • [ ] Update doc-strings where appropriate.
  • [ ] Update or write new documentation in packit/packit.dev.
  • [ ] ‹fill in›

Fixes #882

Related to #866

Merge before/after

RELEASE NOTES BEGIN

Packit now supports automatic ordering of ☕ after all checks pass.

RELEASE NOTES END

olamidepeterojo avatar Mar 19 '25 16:03 olamidepeterojo

My apologies, I forgot to add the license so i will amend and push

olamidepeterojo avatar Mar 19 '25 16:03 olamidepeterojo

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/bf244d244747414495dc2f1f86815233

:x: pre-commit FAILURE in 2m 49s :x: ogr-tests-pip-deps FAILURE in 2m 04s

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/2fc19189cf6f43f0b8a94c3b97beeee0

:x: pre-commit FAILURE in 2m 50s :x: ogr-tests-pip-deps FAILURE in 2m 07s

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/b2745773581740398e8fd5abb4e61f67

:x: pre-commit FAILURE in 2m 57s :x: ogr-tests-pip-deps FAILURE in 1m 53s

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/6e069cacddc1438799aae25b087c957c

:x: pre-commit FAILURE in 2m 51s :x: ogr-tests-pip-deps FAILURE in 2m 09s

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/435e7db689d44a038e3c39b78d0422ba

:heavy_check_mark: pre-commit SUCCESS in 2m 52s :x: ogr-tests-pip-deps FAILURE in 2m 16s

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/10d6690c49564bbaa59df93f5d2d4c82

:heavy_check_mark: pre-commit SUCCESS in 2m 37s :heavy_check_mark: ogr-tests-pip-deps SUCCESS in 17m 14s

Hi @olamidepeterojo !

Thank you for all the contributions. I have a few generic suggestions so your contributions can be accepted more easily.

  • You might want to take a look at our contribution guide that covers a lot. What tools do we use and how we test things.
  • I would suggest looking at other Forgejo contributions to see how you can do things.
  • A note on AI. (As Matěj has pointed out, a few things look really suspicious.;-) Using AI is fine, but it can quite easily hallucinate (e.g. use non-existing properties, API endpoints,...) and might also not fit the project (e.g. introducing another way how we test things.)
  • Also, play with the code locally so you can catch the issues more easily. This helps one better understand the code as well.

Let us know if you need any guidance.

lachmanfrantisek avatar Mar 27 '25 13:03 lachmanfrantisek

Thank you @lachmanfrantisek. I have taken notes of your suggestions.

olamidepeterojo avatar Mar 27 '25 18:03 olamidepeterojo

Hello @mfocko , could you kindly review for incase there are changes to be made?

olamidepeterojo avatar Mar 30 '25 10:03 olamidepeterojo