pachli-android
pachli-android copied to clipboard
Clear up classes of lint errors
The code contains many instances that Android Lint would warn about.
When linting was made mandatory for CI a "baseline" file was created which grandfathers in those problems so that the lint check will ignore them for the time being (see https://developer.android.com/studio/write/lint#snapshot).
Those issues still need to be cleared up.
This is the top-level issue to do that. If you are interested in working on this:
- Review https://github.com/pachli/pachli-android/blob/main/app/lint-baseline.xml
- Identify a class of lint warning you want to fix (e.g., at the time of writing there are many
UnknownNullnessissues). - Create a new GitHub issue to track the work to fix this -- link back to this issue from that one -- so that other people know that you are working on it (the new GitHub "Create sub issue" feature also works well for this).
- Fix the issue in a new PR
You will need to update the baseline file in the new PR as well. To do that.
- Recreate the file with
./gradlew newLintBaseline - Verify the baseline file deletes the issues you have fixed, and does not add new issues (the line numbers for existing issues may have moved)
- Add the changes to
app/lint-baseline.xmlto the PR