pachi81
Adding chart to GDH
@froster82 new strings are available for translation @Ginocar new strings are available to check the translation
No hurry, as I have holidays next week ;-)
@froster82 new strings are available for translation @Ginocar new strings are available to check the translation
No hurry, as I have holidays next week ;-)
Ok. Thank you
@pachi81, first of all - the graph looks effing awesome! Great job! I already see a couple of things to correct in the existing strings. Aaaand I have a couple of ideas for implementation, but I will leave this for now and will write all the things I came up with a bit later.
@pachi81, I updated PL strings. When using the lates version I came up with the following thoughts:
- The best looking widget on the phone is 2x3 or 2x4. Then there is nothing to change. However, when somebody adds one widget showing say glucose value and trend in 1x2 format and another widget for the graph, it would be nice if the second widget, on tapping it, could run any other action. Meaning: 1st widget showing glucose, when tapped, runs Juggluco. 2nd witget showing graph - runs GDH app. This is just for the ease of use. Frankly - this could be also useful on the watchface if we have more than one complication from GDH.
- Think about a widget for the delta section showing delta values for 1 min., 5 min. and 15 min. as in the app itself. Sometimes it could be useful.
- In the app itself, in the Settings, in Widgets, in the top section there are options related to the floating widget. The section is disabled, however, two last options (action on tap and graph duration) are now still active and are quite misleading. Can you disable those options in this section, unless the switch for floating widget is enabled?
- Now for the graph itself - I know this might be hard, looking back on the implementation problems, but it's worth to ask. Can the graph height be scalable? I mean, if the glucose value on the whole graph duration is within the boundaries of say 70 and 160, can the graph show only this range? And not from 0 to 200 as it is now.
- I also noticed something different. Today I changed my sensor, and in Juggluco I still have the readings from the old one (2 sensors side by side). In the previous versions, GDH showed data from both sensors without any problem. Now, when there is a graph, GDH seems to be stuck only on one sensor - the old one. For a bit GDH showed readings from both sensors, but afer a while it reverted to showing only the older sensor data. This is not a bug, but maybe an issue for observation.
All in all, the graph looks awesome. I cannot wait for DMM to make a watch face with the graph from GDH :)
@pachi81 I noticed 3 new ones at the end. Is there still one more?
Yes, the one over the last 3 ones. I already translated it, as it was needed for Google verification for the new permission.
@pachi81, can you please check something? I started playing around with AOD options. While the data appears fine, its size can be modified, but I cannot change the vertical position. No matter what value is entered, the graph and other options are always shown just above the fingerprint reader icon. I am on galaxy S24+ with Android 14.
@pachi81, can you please check something? I started playing around with AOD options. While the data appears fine, its size can be modified, but I cannot change the vertical position. No matter what value is entered, the graph and other options are always shown just above the fingerprint reader icon. I am on galaxy S24+ with Android 14.
Oh, seems to be a bug. I will fix it. Thank you for reporting. As it fits my vertical pos, I have not checked...
Oh, seems to be a bug. I will fix it. Thank you for reporting. As it fits my vertical pos, I have not checked...
Oh, it fits mine as well, but I wanted to check it anyway :) I did not check the background vertical option, though.
One more thing. Can you enable showing the axis descriptions on the graph on AOD? I prefer having the time and glucose levels visible on the graph, and have this option enabled on the widget. Maybe also as an option as in the case of widgets?
@froster82 can you check this string change: https://github.com/pachi81/GlucoDataHandler/pull/202/commits/2d6fd19ef7440e8e5efeeab0caf4505bab5964da#diff-0908d478f1e1608a4d8bf0d6e84f3c23dd963a61f2ff17a7984af7e3e9f938d1
@pachi81, the first change is just a little one. The second, however, relates to a cut portion of text. In PL version the last word of that string was transferred to 5th line, and thus invisible in the app. By removing the "enter" now we should have the whole text in 4 lines.
@pachi81, the first change is just a little one. The second, however, relates to a cut portion of text. In PL version the last word of that string was transferred to 5th line, and thus invisible in the app. By removing the "enter" now we should have the whole text in 4 lines.
@froster82 do you think, that these language issues are critical ones? I create the first release candidate yesterday and it is already in the queue for beta testing. If there is no additional issue, I would release this version to public and do not create an additional version...
@pachi81, no, these are not critical ones. They can wait for sure. Sorry, I had no chance to introduce them earlier, as I started reviewing the app itself after the last update only yesterday ;/
@froster82 There will be an additional version, because I have seen some OutOfMemory exceptions. Therefor I will shorten the time in the graph on phone to 2 days by default. I added a new setting for, can you translate it:
<string name="graph_days_phone_main">Number of days</string>
<string name="graph_days_phone_main_summary">Number of days which are available in the graph.\nIMPORTANT: too many days can cause memory issues!</string>
@pachi81 , I will paste them here, as it seems you have not edited the files yet :)
<string name="graph_days_phone_main">Liczba dni</string>
<string name="graph_days_phone_main_summary">Liczba dni widocznych na wykresie.\nUWAGA: zbyt duża liczba dni może powodować problemy z pamięcią telefonu!</string>
@pachi81, if you need to make yet another version before the final release, let me know. I might still change something in the Polish strings. Just to look better. Nothing critical, though.
@froster82 I haven´t put the current version from yesterday to beta tester approval. So, if you like, you can do some more changes and I create a new version.
I noticed some texts in PL being cut, so I transferred them to another line. We'll see how it looks now.
@froster82 New line will not save the problem. I think it gets cut, if the text is too long. But I´m not sure, what is the max length. Maybe it is phone related. So, if it gets cut you have to try to shorten it.
The text is cut when there is a switch on the right. Otherwise the text is transferred without any problem to the next line. I compared the length of other strings and those cut should also be visible. But they are as if hidden by the switch. We'll see.
@pachi81, nope, you're right. I will need to change them to something shorter, because there is no change.
@pachi81, one more question for a possible bug. Can you check the AOD color option?
when I enable the Coloured AOD option there is no change. The AOD glucose value and graph are still white. However, the trend arrow from GDH notification is in colour.
The firs photo is with Colour option disabled, and the second with it enabled. No change.
samsung s24+ and Android 14.