ppml: additional_regressors is not really NULL by default?

[MatthieuStigler]

According to ?ppml,

additional_regressors: By default this is set to NULL.

But it seems by default it is missing, not NULL? See below.

Also, I would suggest removing the dependence on dplyr for this specific example, as subset() does the same here?

library(gravity)
#> Gravity 1.1
#> If this package is useful, please support it. https://www.buymeacoffee.com/pacha.
#> 
#> Attaching package: 'gravity'
#> The following object is masked from 'package:stats':
#> 
#>     nls
data("gravity_no_zeros")

# Choose 5 countries for testing
countries_chosen <- c("AUS", "CHN", "GBR", "BRA", "CAN")
grav_small <- subset(gravity_no_zeros, iso_o %in% countries_chosen)

fit <- ppml(
  dependent_variable = "flow",
  distance = "distw",
  data = grav_small
)
#> Error in ppml(dependent_variable = "flow", distance = "distw", data = grav_small): argument "additional_regressors" is missing, with no default

^{Created on 2024-11-21 with reprex v2.1.1}

[pachadotdev]

According to ?ppml,

additional_regressors: By default this is set to NULL.

But it seems by default it is missing, not NULL? See below.

Also, I would suggest removing the dependence on dplyr for this specific example, as subset() does the same here?

library(gravity)
#> Gravity 1.1
#> If this package is useful, please support it. https://www.buymeacoffee.com/pacha.
#> 
#> Attaching package: 'gravity'
#> The following object is masked from 'package:stats':
#> 
#>     nls
data("gravity_no_zeros")

# Choose 5 countries for testing
countries_chosen <- c("AUS", "CHN", "GBR", "BRA", "CAN")
grav_small <- subset(gravity_no_zeros, iso_o %in% countries_chosen)

fit <- ppml(
  dependent_variable = "flow",
  distance = "distw",
  data = grav_small
)
#> Error in ppml(dependent_variable = "flow", distance = "distw", data = grav_small): argument "additional_regressors" is missing, with no default

Created on 2024-11-21 with reprex v2.1.1

good catch!! that must have sneaked in rushing something for cran changes