Paul Wise comments

Results 249 comments of


                                            Paul Wise

cmake: add `sptag-` prefix to the names of the binaries

Also the GPU binaries need to be adjusted in `GPUSupport/CMakeLists.txt`.

cmake: drop unused `COMPONENTS` from `find_package(Boost 1.67)`

On older versions of Boost (1.67 is affected, 1.74 is not), the `boost::system::system_category()` function is undefined at link time unless the `system` component is included.

test failure when building on Linux in tmpfs due to the use of `O_DIRECT`

I suggest detecting when the file open failed due to missing `O_DIRECT` support and opening the file again without using `O_DIRECT`.

cmake: build executables, libraries and bindings files on `obj` dir

To be clear on the swig changes, in `Wrappers/CMakeLists.txt`, every reference to `${PROJECT_SOURCE_DIR}/Wrappers/inc/*wrap*` or `${PROJECT_SOURCE_DIR}/Wrappers/inc/*.{py,java,cs}` files need to be replaced with references to `${CMAKE_BINARY_DIR}/*wrap*` and `${CMAKE_BINARY_DIR}/*.{py,java,cs}`. I have tested that...

cmake: build executables, libraries and bindings files on `obj` dir

In addition, the `ADDITIONAL_CLEAN_FILES` property needs to be set using `set_property` to the corresponding `*wrap*` and `.{py,java,cs}` for each of the targets in `Wrappers/CMakeLists.txt`, so that `make clean` within the...

print reason for file handle creation failure

This will be helpful to diagnose the [SPTAG build failures in Debian](https://buildd.debian.org/status/logs.php?pkg=sptag&arch=amd64).

cmake mistake

Seems like this issue can be closed?

Fix typos in Quick Start doc

This is missing a typo fix: `indexbuiler` should be `indexbuilder`.

cmake: run the tests by default

Looks like this is required in the main cmake file order to run the tests: ``` include(CTest) ```

SPTAGTest KDTReconstructTest failure: Assertion `quantizer' failed.

Looks like merging #294 would also fix this issue, since the try-dispatcher branch is for that PR. @PhilipBAdams could you submit a separate PR for the test fix please?