ionic2-elastic-header icon indicating copy to clipboard operation
ionic2-elastic-header copied to clipboard

Published 20 hours ago • verified publisher icon pablozandona

Ionic 4 Support

Open SteveKennedy opened this issue 6 years ago • 2 comments

I absolutely love this feature, and have relied on it for building a really cool app for Ionic 2+3.

Ionic 4 no longer supports the full ionic-angular library, and now uses a @ionic/angular library. So when I use this elastic header feature, I get:

[ng] ERROR in node_modules/ionic2-elastic-header/dist/elastic-header.directive.d.ts(2,25): error TS2307: Cannot find module 'ionic-angular'

Any plans to consider to make this Ionic 4 compatible?

SteveKennedy avatar Aug 12 '18 01:08 SteveKennedy

Hi, Find the find file through the error, then modify the lib to this '@ionic/angular', the error will be gone... however the seems this lib isn't compatible with ionic 4

AbbasTallaq avatar Oct 05 '18 15:10 AbbasTallaq

It should be possible to use the directive in Ionic 4 with only a few small changes.

Open the directive and change the ‘Content’ import to ‘IonContent’ (in the '@ Input' statement as well). After that, change ‘ev.scrollTop’ to ‘ev.detail.scrollTop’.

I tried to upload a patch but apparently this is not supported.

BorisRnl avatar Mar 09 '19 14:03 BorisRnl