Pablo Palacios

Results 19 comments of Pablo Palacios

@billyrrr yeah, I completely understand what you are saying. Currently `useFluxible` is just a primitive hook that doesn't do much more than using the `useContext` to fetch fluxible context and...

@billyrrr regarding using props inside `getStateFromStore`, I'm pretty sure that it will not work (with the implementation that I proposed), since `getStateFromStore` will not be called when the props changes...

@billyrrr I've created an example to demonstrate the stale props with the current `connectToStores` function. Since it's already an issue there, I think there are no blockers to already start...

@ljharb the tests are expected to fail since they use a version of `react-shallow-renderer` that does not have support for `contextType`. We need to merge [this PR](https://github.com/enzymejs/react-shallow-renderer/pull/100) first.

@ljharb it depends on `react-test-renderer` which depends on `react-shallow-renderer`.

Hi, is there any blocker for this one? I might be able to allocate people in my team to work on it (both in UX and tech) if there are...

The current behaviour mimics jest behaviour which is pretty fine if you follow this workflow: 1. Write a test 2. Write a stub implementation which will generate a dumb snapshot...

Besides e10s, some plan to web extensions? I've took a look at codebase and I know that would be hard (if not impossible) to migrate keysnail to a web extension....

@ljharb I've updated my branch with the tests. I also renamed the tests that are using the legacy `contextTypes` property.