pablomartin4btc
pablomartin4btc
> > As @Sjors mentioned above please consider adding -rpcclienttimeout=0 to the calls also in the documentation. Furthermore, these example outputs could be useful there too. > > Can you...
@kohend are you able to test @furszy's fix?
> Tested on Ubuntu 24.04. It works with `QT_QPA_PLATFORM=xcb`, but fails with `QT_QPA_PLATFORM=wayland`. I'll take a look, thanks!
@hebasto it seems there are some [issues](https://gitlab.freedesktop.org/wayland/wayland/-/issues/233) with Wayland on how these actions are being handled ([this one specific](https://bugs.kde.org/show_bug.cgi?id=462574) to KDE but found some old ones in [gnome](https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/730)). As a...
> I think we should first fix our `GUIUtil::bringToFront()` first in a separate PR, which will also address similar issues in other cases. > > Then we can apply the...
Updates: - No functional changes: - Using GUIUtil::bringToFront() that was recently fixed (and merged) for `Wayland`; - Removed unnecessary extra line in (`src/qt/transactiondescdialog.h`).
Updates: - Addressed @luke-jr's [feedback](https://github.com/bitcoin-core/gui/pull/815#pullrequestreview-2013545536).
> ```c++ > historyAction->setEnabled(enabled && !isPrivacyModeActivated()); > ``` ~~Just replacing the operator with `||` (e.g. when the user closes all wallets, all tabs will be disabled except for `Transactions`).~~
Updates: - Addressed @luke-jr's [feedback](https://github.com/bitcoin-core/gui/pull/815#pullrequestreview-2072577992).
> This one-line change works without anything else: > > [#815 (review)](https://github.com/bitcoin-core/gui/pull/815#pullrequestreview-2072577992) Sorry, I made another mistake, thanks for double checking. To other reviewers: please hold on till next push,...