pablomartin4btc

Results 123 comments of pablomartin4btc

> if the `HTTPRequest` object is created successfully (once `replySent` is removed and the test does `try/catch`). If the input is such that `HTTPRequest:HTTPRequest()` throws, then it does not have...

Updated changes: - Split commit in 2 (as suggested by @stickies-v and @vasild): one for the fix and one for the logic improvement. - Added some comments to each commit...

> Left some comments on the bugfix commit. I'd carve that out in a separate PR to get it merged for v25. I'll create a new PR linked to this....

> I agree with suggestions from @stickies-v, would be happy to re-review. I'll let you both know ones the new PR is ready, very soon. Thanks.

Updated changes: - Created new PR #27468 with a minimal bugfix and single commit in order to merge it faster for 25.0 release, as suggested above by [@stickies-v](https://github.com/bitcoin/bitcoin/pull/27253#pullrequestreview-1385130381) and supported...

Updated changes: - First commit of this PR was already merged into 25.0 release branch (#27468). - Rebased & incorporated some nits & suggestions from latest reviews including above PR....

Rebased + fix correct usage of `utf8string()` instead of `u8string()`.

Updates: - Switched the logic strategy to the previously presented alternative due to preference of reviewers @kevkevinpal & @furszy (thanks!); - Added test coverage

Addressed @furszy's [feedback](https://github.com/bitcoin/bitcoin/pull/28670#discussion_r1456421159).

Addressed @hebasto's [suggestion](https://github.com/bitcoin/bitcoin/pull/28670#discussion_r1457712659) in order to fix the MSVC CI job.