pablomartin4btc

> re ACK [fa48d46](https://github.com/bitcoin/bitcoin/commit/fa48d460334beef43fa73455aa9e30971d33c1b2) Just a nit (only if you update) : your second commit title seems to suggest that it's gui related, instead of cli. Yeah, there was an...

> Are you still working on this? I'm about to continue, sorry for the delay!

Updates: - I've been working on @jonatack's latest feedback, I'm performing some tests at the moment and will update the code soon.

Updates: - Addressed [feedback](https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-1860423961) provided by @jonatack regarding first commit 6898219043f42ae42e4703c549e656f56d276d13. - Updated second commit cf7dd3564a3ace4153a32930f36bd78432b59097 following some directions [given](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1483546926) by @jonatack and [discussed](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1573464319) with @andrewtoth. - Fixed incorrect commit...

> Also, "protocol.h" in the first commit message body seems wrong or out-of-date here: `bringing the error message in line with the definition established in protocol.h ("error when there are...

Updates: - Addressed latest @jonatack's [feedback](https://github.com/bitcoin/bitcoin/pull/26990#pullrequestreview-2078072832): - Removed [unnecessary](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1614031474) trailing `.` from CLI error messages. - Reconsidered previous [suggestion](https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1614026697) about the `RPC_WALLET_NOT_SPECIFIED` error handled in `src/bitcoin.cli` and the returned message....

> For instance, the tests that pass a wallet CLI option to a non-wallet CLI command (-generate) seem to be mixing issues under test... > > ```diff > - #...

> What do you think? As @stickies-v explained to me outside this PR: "... by moving the uri parsing to http_request_cb we're failing super early, and even when the query...

Updated changes: - move the validation/parsing logic up in the stack as soon as the request is initiated even before the work item thread is created - updated unit and...

@fanquake that's something perhaps I've introduced with my last push, I'm on it, thanks. Weird, it's not failing locally for me: ``` $ ./test/functional/interface_rest.py 2023-03-16T21:14:11.025000Z TestFramework (INFO): PRNG seed is:...