Pablo Brasero

Results 297 comments of Pablo Brasero

I've gone through this again, experimenting and comparing the behaviour currently in `main` with the behaviour proposed here. Now I'm newly confused and I'm not sure about what we are...

@gh-axel-czarniak - The problem is that when rendering the headers we don't know what the class is yet. So if we have `Car < Vehicle` and `Boat < Vehicle` and...

Thank you again. I have been playing with it today and have pushed some changes to my fork: https://github.com/thoughtbot/administrate/compare/main...pablobm:administrate:feature/inherit_partial. What do you think? Some comments: Re: `if superclass == Administrate::Field::Base`...

Good point 🙂 One last thing: I have removed the `private_class_method` declaration, as we don't do that anywhere in the codebase. I prefer not to introduce new idioms unless we...

Merging! Thank you, twice: for your contribution and for your patience :medal_sports:

Thank you for this. I hope I can remember things clearly, let's see what we can do here... :eyes: ### `sortable` option First, you are also introducing the `sortable` option,...

@goosys - Sounds good :slightly_smiling_face:

I think this is it? (Apart from the two small suggestions now). Do you think there's anything else to cover or should we go and merge? Tangentially: I need to...

One last thing. Sorry! :sweat: 1. I saw a couple of `read_value` that I don't think are used anywhere and removed them. Also removed the default value `data = nil`...

Re: `current_path`, no idea :sweat_smile: I wasn't seeing the problem so I was not aware. But if your change appears to fix things, then that's good :+1: Merging at last!...