Pablo Baxter

Results 42 comments of Pablo Baxter

At this time, Harmony is meant to just be a re-implementation of `SharedPreferences`, with minor fixes to the implementation. This would be a move away from the current `SharedPreferences` interface....

I'm saying that if you make a call to something like `sharedPrefs.edit().putBoolean("foobar", true).apply()`, you should also add in `"foobar"` to a hash set, and in the `OnPreferenceChangeListener` of the same...

Regardless of when the key comes in, when you query the SharedPreferences, it'll give you the latest value stored. For example, if you call `prefs.edit().putInt("foo", prefs.getInt("foo", 0) + 1).commit()` twice,...

This is a feasible feature with the given the current `SharedPreference` implementation. It's just a matter of creating a new implementation of the `OnSharedPreferenceChangeListener`, and letting Harmony handle that class...

I'm curious if this also happens in the Android `SharedPreference` as well. I believe it _may_ be a deadlock of the main thread, as the call to `commit()` blocks the...

I think I found the bug, and it has to do with the timing of the changes. Essentially, when you call the following on the first process: ``` // Primary...

> Hey Pablo have you had a chance to look at this? Would love to use this more efficient library. Unfortunately not. I do plan to get to this issue...

Thank you @bddckr for reporting this issue. This normally happens when you don't have the `org.jetbrains.kotlin:kotlin-gradle-plugin-api` dependency in the build class path. You can add this to your root `build.gradle`...

There's something off with the `PropertiesModelBuilder` in the [SqlDelightPlugin](https://github.com/sqldelight/sqldelight/blob/master/sqldelight-gradle-plugin/src/main/kotlin/app/cash/sqldelight/gradle/SqlDelightPlugin.kt). The `PropertiesModelBuilder` takes in a collection of `SqlDelightDatabase`, however this is done for every project this plugin is applied to. It...

> AFAIK , the Gradle Tooling will be run for each Gradle project Yes, but the problem is with how the builder is registered. It's done so each time the...