Pascal Berrang

Results 28 comments of Pascal Berrang

Not a priority at the moment and needs more discussion.

This will unfortunately still cause problems on macOS due to the first few lines: ``` set -o errexit set -o nounset set -o pipefail ```

Yes, you're partially right: ``` Starting seed node... Done. Starting validators... Starting Validator: 1 Starting Validator: 2 Starting Validator: 3 Starting Validator: 4 Done. ./scripts/devnet/devnet.sh: line 340: kindexes[*]: unbound variable...

Will be merged as part of #1235

What is the impact on our security model? Should be more or less equivalent to the old model, right (validators that are offline for a short time do not lose...

It will be difficult to make this accessible from the transaction itself. However, that's what the `Log` mechanism was designed for: to get more meaningful "events" related to specific addresses....

The problem that occurs is that the bind volume isn't mounted during the build process. Thus, when running the container and mounting the (empty) bind volume, the `/var/www/html` directory is...

Also, while reviewing the failing tests, I stumbled across the following code from Bruno (`check_signers` function): ```rust // num_signers >= min_signers num_signers.is_cmp(&min_signers, Ordering::Greater, true) ``` It looks to me that...

> It looks to me that there's a mismatch between the comment and the code. We should ensure consistency between the circuit code and our regular consensus condition though. If...