codeclimate-action icon indicating copy to clipboard operation
codeclimate-action copied to clipboard

Does not run on macos-14

Open isaachinman opened this issue 1 year ago • 3 comments

This action does not successfully run on the hosted macos-14 runners.

I get the following error:

/Users/runner/work/_actions/paambaati/codeclimate-action/v5.0.0/lib/utils.js:58
                throw new Error(`Download of '${url}' failed with response status code ${response.status}`);
Error: 🚨 CC Reporter download failed!
                      ^
Error: Download of 'https://codeclimate.com/downloads/test-reporter/test-reporter-latest-darwin-arm64' failed with response status code 403
    at /Users/runner/work/_actions/paambaati/codeclimate-action/v5.0.0/lib/utils.js:58:23

isaachinman avatar Apr 17 '24 17:04 isaachinman

@paambaati Would love to see this fixed ASAP and am happy to help. Otherwise we will need to switch away to another CodeClimate action, or write our own. There are hosted darwin builds for OSX.

isaachinman avatar Apr 18 '24 08:04 isaachinman

The key problem here is arm64 vs amd64. Actually, I wonder if this is a CodeClimate limitation?

isaachinman avatar Apr 18 '24 08:04 isaachinman

It is indeed a CC limitation; see https://github.com/paambaati/codeclimate-action/blob/749a6d38dd25db47aba7d93e78a60a6bff6df89f/test/integration.test.ts#L14-L20

paambaati avatar Apr 18 '24 08:04 paambaati

@paambaati I see the integration test code above, but it's actually failing instead of skipping, is this expected? E.g.:

image

https://github.com/rogerluan/arkana/actions/runs/9431336943/job/25979873736

rogerluan avatar Jun 08 '24 20:06 rogerluan

@rogerluan This is expected, because CodeClimate does not publish ARM64 images — see https://github.com/codeclimate/test-reporter

I will make sure there’s a more obvious error message in the next release.

paambaati avatar Jun 09 '24 14:06 paambaati

My bad, I thought the code above was a check in the runtime code that would print that message in case it was running on macOS, but it's just an integration test, not the actual code right 😅

I guess I'll have to build for linux if I want to upload code coverage then 😬 since it looks like they're not interested in fixing that.

Thanks @paambaati

rogerluan avatar Jun 11 '24 12:06 rogerluan

Please upgrade to v8.0.0 of this action and you should be able to see a more obvious error when using an unsupported environment.

paambaati avatar Jun 12 '24 07:06 paambaati