grafana-trackmap-panel icon indicating copy to clipboard operation
grafana-trackmap-panel copied to clipboard

Started work on feature to resolve #18

Open RmStorm opened this issue 4 years ago • 2 comments

Hello I wrote a quick demo with a colleague to implement this feature, there is two small problems with it but it will probably be finished soon. I just thought I would put the work in a draft PR so you can have a look at it!

RmStorm avatar Oct 18 '19 09:10 RmStorm

Thanks for looking into this! I had also started playing around with tooltips at one point but hadn't really decided how I wanted to move forward with it. I've just pushed my WIP code to the wip/tooltips branch so you can take a look at it.

The rough idea was that if you configured the plugin as table data, you could define specific "rows" for latitude, longitude, tooltip, etc. This would make it flexible enough to make it easier to add some of the other features that people have been asking about in the future. For backwards compatibility I made the current way (2 streams - lat and long) automatically upconvert into the table format. I don't know if this is the "right" way of doing this though.

pR0Ps avatar Oct 18 '19 14:10 pR0Ps

Thanks for looking into this! I had also started playing around with tooltips at one point but hadn't really decided how I wanted to move forward with it. I've just pushed my WIP code to the wip/tooltips branch so you can take a look at it.

The rough idea was that if you configured the plugin as table data, you could define specific "rows" for latitude, longitude, tooltip, etc. This would make it flexible enough to make it easier to add some of the other features that people have been asking about in the future. For backwards compatibility I made the current way (2 streams - lat and long) automatically upconvert into the table format. I don't know if this is the "right" way of doing this though.

Your rewrite looks a lot more extensive! I guess it is to accommodate #6 ? I haven't actually looked into how data is transferred from grafana datasources to panels so I'm not sure how it would work to format the data underlying the panel as a table instead of rows. It sounds like a more flexible approach for the use case of this trackpanel.

I'm not exactly sure how to merge the tooltip functionality in this PR with the work in wip/tooltips_branch. What do you think is the best way to proceed from here?

RmStorm avatar Oct 21 '19 09:10 RmStorm