p5 icon indicating copy to clipboard operation
p5 copied to clipboard

Not compatible with Python >=3.11

Open mhechthz opened this issue 1 year ago • 6 comments

On windows the library is not compatible with Python 3.11 since Pillow 9.0.x is not compatible with Python 3.11. Compilation is needed which is never a good idea since it failes on most systems. Python 3.10 works well but is outdated now.

mhechthz avatar Dec 30 '23 07:12 mhechthz

Thank you for submitting your first issue to p5py

github-actions[bot] avatar Dec 30 '23 07:12 github-actions[bot]

@mhechthz can we not change Pillow to its latest version 10.1.0 which is compatible with python 3.11 ? It worked for me so thats why I am suggesting. And if there is any issue with that let me know as I am new to open Source ✌️.

gyan313 avatar Jan 01 '24 06:01 gyan313

Yes @Gyan313, this is exactly what I would like to be changed. So I can directly install the library using pip instead of compiling it on my own machine during installation (which never works on many windows machines and for many colleagues I know).

mhechthz avatar Jan 01 '24 07:01 mhechthz

Thanks, @mhechthz @Gyan313 for testing it out on windows. I should probably add a basic GHA for windows that installs the p5 on it. Would any of you like to make a PR to bump the Pillow dependency?

tushar5526 avatar Jan 02 '24 05:01 tushar5526

@tushar5526 Hi, I'm also working on integrating a pre-commit hook to p5, and I'm currently addressing some flake8 issues. Once I'm finished, I'll submit a pull request to update the Pillow dependency. Whether or not I resolve the flake8 problem, I'll still create a PR for Pillow today. ✌️❤️

gyan313 avatar Jan 03 '24 01:01 gyan313

Hey @Gyan313 awesome to hear about your plans! Just a heads-up on something related to pre-commit already in the pipeline - https://github.com/p5py/p5/pull/460

tushar5526 avatar Jan 04 '24 19:01 tushar5526