goaws
goaws copied to clipboard
[WIP] [aws-json] Migrate SQS SendMessage
- [x] Create a model for your new Request struct
- a. Implement <NewStruct>.SetAttributesFromForm - even if it just returns without doing anything.
- b. You may also need to handle UnmarshalJSON for any nested request attributes/objects.
- [x] Create a RequestFunctionV1 function
- [x] Swap the reference in the routing table to the new V1 routing table
- [x] Copy the code from the old function
- [x] Call utils.REQUEST_TRANSFORMER with your new struct
- [x] Update fetches from the request Form to look at the new struct
- [x] Make the new V1 function return a status and response struct
- [x] Update any references to createErrorResponse to use createErrorResponseV1
- [x] Delete old/non-V1 function
- [ ] Update/Create/Remove unit tests
- [ ] Smoke Test with the SDK
- [ ] Add automated tests in smoke_tests/... (use the v2 SDK as much as possible)
Sorry to late but I'm still alive 👍 . I want to update this within 2 or 3 weeks...
Hi @Admiral-Piett, this is ready for review 👍
@Admiral-Piett I updated the PR!
Oh, one other tiny thing, would you mind squashing your commits? I think it's easier in the long run to track things when there's 1 commit per "change".
I squshed the commits! Can you please merge it when you would like? Since it looks like I cannot merge it myself (it's good).