goaws icon indicating copy to clipboard operation
goaws copied to clipboard

[WIP] [aws-json] Migrate SQS SendMessage

Open kojisaikiAtSony opened this issue 11 months ago • 1 comments

  • [x] Create a model for your new Request struct
    • a. Implement <NewStruct>.SetAttributesFromForm - even if it just returns without doing anything.
    • b. You may also need to handle UnmarshalJSON for any nested request attributes/objects.
  • [x] Create a RequestFunctionV1 function
  • [x] Swap the reference in the routing table to the new V1 routing table
  • [x] Copy the code from the old function
  • [x] Call utils.REQUEST_TRANSFORMER with your new struct
  • [x] Update fetches from the request Form to look at the new struct
  • [x] Make the new V1 function return a status and response struct
  • [x] Update any references to createErrorResponse to use createErrorResponseV1
  • [x] Delete old/non-V1 function
  • [ ] Update/Create/Remove unit tests
  • [ ] Smoke Test with the SDK
  • [ ] Add automated tests in smoke_tests/... (use the v2 SDK as much as possible)

kojisaikiAtSony avatar Mar 14 '24 07:03 kojisaikiAtSony

Sorry to late but I'm still alive 👍 . I want to update this within 2 or 3 weeks...

kojisaikiAtSony avatar Apr 02 '24 03:04 kojisaikiAtSony

Hi @Admiral-Piett, this is ready for review 👍

kojisaikiAtSony avatar May 08 '24 03:05 kojisaikiAtSony

@Admiral-Piett I updated the PR!

kojisaikiAtSony avatar May 15 '24 13:05 kojisaikiAtSony

Oh, one other tiny thing, would you mind squashing your commits? I think it's easier in the long run to track things when there's 1 commit per "change".

Admiral-Piett avatar May 20 '24 21:05 Admiral-Piett

I squshed the commits! Can you please merge it when you would like? Since it looks like I cannot merge it myself (it's good). image

kojisaikiAtSony avatar May 22 '24 01:05 kojisaikiAtSony