p4c icon indicating copy to clipboard operation
p4c copied to clipboard

Published 20 hours ago • verified publisher icon p4lang

[#4656] Revert PR #3633 so that mux expressions will be constant folded

Open kfcripps opened this issue 9 months ago • 3 comments

Reverts https://github.com/p4lang/p4c/commit/4a74084c675a3e8bdf7a318e468cbd5bb27c6914, as discussed as an alternate fix for #4656 in https://github.com/p4lang/p4c/pull/4657.

kfcripps avatar May 09 '24 16:05 kfcripps

Looks like this is supceded by #4657, so this can be closed?

ChrisDodd avatar May 10 '24 00:05 ChrisDodd

@ChrisDodd It is an alternate approach to #4657. I plan to close one after the other is merged.

kfcripps avatar May 10 '24 00:05 kfcripps

As mentioned in #4657, I'm actually preferring this PR at this point.

kfcripps avatar May 10 '24 02:05 kfcripps

https://github.com/p4lang/p4-spec/issues/1281 determines whether we may merge this particular PR, too.

fruffy avatar May 15 '24 16:05 fruffy

superseded by https://github.com/p4lang/p4c/pull/4657

OK, so should this one be closed now?

vlstill avatar May 16 '24 07:05 vlstill

Sure, it will need to be rebased even if the outcome of https://github.com/p4lang/p4-spec/issues/1281 is to remove the error.

kfcripps avatar May 16 '24 12:05 kfcripps