p4c icon indicating copy to clipboard operation
p4c copied to clipboard

Published 20 hours ago • verified publisher icon p4lang

Enable loopsunrolling by default [recreated]

Open fruffy opened this issue 2 years ago • 3 comments

Recreation of #2921 with a different source branch.

This is a quick edit to check what happens if you enable parser unrolling for the entire p4test back end. Let's see what breaks.

fruffy avatar Mar 22 '22 15:03 fruffy

Please do not merge, instead rebase the branch. I will refresh the ref files.

fruffy avatar Jun 17 '22 16:06 fruffy

I think that we have two bugs left in parserUnroll for this test suite:

  1. p4/testdata/p4_16_samples/invalid-hdr-warnings6.p4 (Failed)
  2. p4/testdata/p4_16_samples/issue561.p4 (Failed) They fixed in #3342 and #3193 PR's. We can continue after they will be merged.

VolodymyrPeschanenkoIntel avatar Jun 21 '22 10:06 VolodymyrPeschanenkoIntel

@VolodymyrPeschanenkoIntel There is two types of errors left. One of them is new it seems.

fruffy avatar Jun 22 '22 19:06 fruffy

@VolodymyrPeschanenkoIntel Can you take a look at the last two failing tests?

fruffy avatar Dec 16 '22 10:12 fruffy

@fruffy Is this PR still useful? Or perhaps other PRs have done everything you planned to do with this one already?

jafingerhut avatar Aug 20 '23 00:08 jafingerhut

@fruffy Is this PR still useful? Or perhaps other PRs have done everything you planned to do with this one already?

It is effectively a debugging PR for the loopsunrolling pass. It has not been merged yet because it was not 100% clear whether the pass is bug free. Let me rebase it.

fruffy avatar Aug 20 '23 10:08 fruffy