p4-spec icon indicating copy to clipboard operation
p4-spec copied to clipboard

add +: slices

Open ChrisDodd opened this issue 1 year ago • 3 comments

ChrisDodd avatar Oct 12 '24 01:10 ChrisDodd

I'm unclear whether these changes need to be also in the asciidoc version, or if that happens automatically. Or perhaps we should wait until after the switchover to asciidoc and do it only there.

ChrisDodd avatar Oct 23 '24 22:10 ChrisDodd

I think it is worth discussing at the next LDWG meeting, exactly when Madoko -> AsciiDoc conversion happens.

Fortunately, for text paragraphs with little or no markup, it usually makes no difference. That said, the changes are so extensive for Madoko->AsciiDoc that I expect if that change is made before this PR, some small changes may be required in this PR. I think small changes to a PR like this to update it will not be wasted effort.

jafingerhut avatar Oct 24 '24 00:10 jafingerhut

@ChrisDodd Sorry for the inconvenience, but we have, after several months of planning, transitioned the P4 language specification source from Madoko to AsciiDoc. Thus most or all of your PRs will need to be updated so that they apply to that version. Hopefully this should be fairly straightforward, e.g. by looking at examples of how things like section headings, bullet items, etc. are marked up in the latest version of the file P4-16-spec.adoc

If you have questions on how to change things for AsciiDoc, feel free to ask. Note that creating a new PR with similar changes as this PR might be easier than updating this PR.

jafingerhut avatar Nov 14 '24 05:11 jafingerhut

@vlstill Please take another look to see if you have any further comments or questions, and if not, please approve.

jafingerhut avatar Mar 10 '25 20:03 jafingerhut

@vlstill Please take another look to see if you have any further comments or questions, and if not, please approve.

The intent is that any compile-time known bit<W>, int<W>, or int type value should be allowed for value L, and any run-time variable value with type bit<W>, since we can guarantee it is non-negative at compile time, but disallow runtime variable values with type int<W>.

jafingerhut avatar Mar 10 '25 20:03 jafingerhut

@vlstill, please take another look or let us know if this is ready to merge so I can merge it. Otherwise, @jonathan-dilorenzo and @vlstill can discuss this in the September LDWG.

jonathan-dilorenzo avatar Aug 05 '25 01:08 jonathan-dilorenzo