p4-spec icon indicating copy to clipboard operation
p4-spec copied to clipboard
verified publisher icon p4lang

Revert "Update parser value set types"

Open jnfoster opened this issue 3 years ago • 3 comments

Reverts p4lang/p4-spec#873

jnfoster avatar Apr 04 '22 20:04 jnfoster

Why should we revert the value set types?

mihaibudiu avatar May 01 '22 02:05 mihaibudiu

Yes I don't see why can't signed types be valid here? (the bitwise operators are valid for fixed signed integer types even).

For serializable enum case, should it decay to the underlying type instead or does it keep it as the enum type?

apinski-cavium avatar May 01 '22 03:05 apinski-cavium

I'd merged this prematurely at the last LDWG...

jnfoster avatar May 02 '22 01:05 jnfoster

Can we close this PR?

mihaibudiu avatar Jan 06 '23 22:01 mihaibudiu

I think it's too late now to consider this, we should just close it.

mihaibudiu avatar May 01 '23 18:05 mihaibudiu