behavioral-model icon indicating copy to clipboard operation
behavioral-model copied to clipboard

Published 20 hours ago • verified publisher icon p4lang

Implement notification support in `SimpleSwitch`

Open pudelkoM opened this issue 2 years ago • 1 comments

This PR implements support for notifications (idle timeouts, digests) in SimpleSwitch when build with PI.

The code of NotificationsCapture is taken verbatim from SimpleSwitchGrpc.

Context: Stratum is consuming the SimpleSwitch[Runner] downstream without gRPC support, as we're implementing that ourselves on top. We'd still like to use digests and idle timeouts, which can be delivered through the PI layer.

pudelkoM avatar Dec 08 '22 21:12 pudelkoM

@pudelkoM please mark this as "Ready for review" when you believe it is ready to be merged

antoninbas avatar Dec 09 '22 19:12 antoninbas

@pudelkoM sorry for the delay, I must have missed the notification when you marked this PR as "Ready for review". I am merging it now.

antoninbas avatar Dec 21 '22 19:12 antoninbas