Backbone.VirtualCollection icon indicating copy to clipboard operation
Backbone.VirtualCollection copied to clipboard

Trigger collection update in _onChange()

Open guilhermeteodoro opened this issue 8 years ago • 1 comments

Hi guys,

I found a bug on Backbone.VirtualCollection during a migration from Marionette 2 to Marionette 3.

I discovered a case where the collection update event should be triggered after a model change event if it doesn't pass through filter (this.accepts()) and already_here is true.

This is a partial fix, just for the 'remove case', but I think that maybe something similar should be done pass through filter (this.accepts()) too.

guilhermeteodoro avatar Nov 25 '16 18:11 guilhermeteodoro

Hi @guilhermeteodoro sorry for the delay.

Do you think you can make an attempt at handling the other cases?

p3drosola avatar Dec 19 '16 17:12 p3drosola